Enable checking for f strings #17732
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: websockets (https://github.com/aaugustin/websockets)
+ src/websockets/sync/messages.py:102: error: Incompatible types in string interpolation (expression has type "None", placeholder has type "int | float") [str-format]
pandas (https://github.com/pandas-dev/pandas)
+ pandas/tests/scalar/test_na_scalar.py:38: error: Unrecognized format specification "xxx" [str-format]
pwndbg (https://github.com/pwndbg/pwndbg)
+ pwndbg/gdblib/symbol.py: note: In function "get":
+ pwndbg/gdblib/symbol.py:100: error: Incompatible types in string interpolation (expression has type "Value", placeholder has type "int") [str-format]
freqtrade (https://github.com/freqtrade/freqtrade)
+ freqtrade/persistence/trade_model.py:852: error: Incompatible types in string interpolation (expression has type "None", placeholder has type "int | float") [str-format]
+ freqtrade/rpc/telegram.py:399: error: Incompatible types in string interpolation (expression has type "None", placeholder has type "int | float") [str-format]
+ freqtrade/rpc/telegram.py:421: error: Incompatible types in string interpolation (expression has type "None", placeholder has type "int | float") [str-format]
+ freqtrade/rpc/telegram.py:446: error: Incompatible types in string interpolation (expression has type "None", placeholder has type "int | float") [str-format]
+ freqtrade/strategy/interface.py:1511: error: Incompatible types in string interpolation (expression has type "None", placeholder has type "int | float") [str-format]
aiohttp (https://github.com/aio-libs/aiohttp)
+ aiohttp/connector.py:1164:32: error: Incompatible types in string interpolation (expression has type "None", placeholder has type "int") [str-format]
+ aiohttp/connector.py:1164:32: note: See https://mypy.rtfd.io/en/stable/_refs.html#code-str-format for more info
materialize (https://github.com/MaterializeInc/materialize)
+ misc/python/materialize/feature_benchmark/comparator.py:56: error: Incompatible types in string interpolation (expression has type "T", placeholder has type "int | float") [str-format]
+ misc/python/materialize/feature_benchmark/comparator.py:65: error: Incompatible types in string interpolation (expression has type "T", placeholder has type "int | float") [str-format]
ignite (https://github.com/pytorch/ignite)
+ ignite/utils.py:134: error: Incompatible types in string interpolation (expression has type "Number", placeholder has type "int | float") [str-format]
+ ignite/utils.py:165: error: Incompatible types in string interpolation (expression has type "Number", placeholder has type "int | float") [str-format]
|
A5rocks
reviewed
Sep 27, 2024
There was a problem hiding this comment.
According to mypy-issues, this PR also fixes:
(I just realized after I ran it that that issue is mentioned in 17714 but whatever.)
There was a problem hiding this comment.
IMO this should go to test-data/unit/check-formatting.test
| if spec.format_spec == ":{}": # most simple dynamic case | ||
| assert ( | ||
| expression is not None | ||
| ) # dynamic spec cannot be last, this should have been detected earlier |
There was a problem hiding this comment.
Would you mind adding a test case? I imagine just "{:{}}".format("aaaa") would work... (I'm not sure what could possibly trigger this though)
| new_format_string = f"{{{spec.conversion or ''}:{next_expression.value}}}" | ||
| parsed = parse_format_value(new_format_string, call, self.msg) | ||
| if parsed is None or len(parsed) != 1: | ||
| continue |
There was a problem hiding this comment.
I assume this happens if the resulting format string isn't a valid format string. Is that caught elsewhere, or does that deserve a self.msg.fail here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #17714
Support for f-string checking was already partially implemented. Consider this code:
Mypy ran these lines through the format checker. The call expressions look like this:
The difference is, that the actually static
"abc"is converted to a "dynamic" spec.This MR attempts to enable type checking of f-strings by inlining these "semi dynamic" specs.
Open Questions:
pytest mypy/test/testcheck.py::TypeCheckSuite::check-string-format.test. It never finds any errors even when it should clearly failChecklist